Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Set the encoding for javac in pantsbuild/pants
Without an encoding explicitly set, javac's encoding will float to whatever the environment has it set to. See #3702 for more info on what we should do to fix this more thoroughly.

- Set the encoding for javac, and refer to a ticket about reifying the setting.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/146201334
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3703/

Bugs closed: 3691, 3702, 3703

Reviewed at https://rbcommons.com/s/twitter/r/4103/
  • Loading branch information
stuhood committed Jul 20, 2016
1 parent cc877f6 commit 4445752
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pants.ini
Expand Up @@ -157,6 +157,8 @@ jvm_options: [
]

args: [
# NB: See https://github.com/pantsbuild/pants/issues/3702
'-C-encoding', '-CUTF-8',
'-S-encoding', '-SUTF-8',
'-S-g:vars',
]
Expand Down

0 comments on commit 4445752

Please sign in to comment.