Skip to content

Commit

Permalink
scrooge_gen task copy strict_deps field (#4321)
Browse files Browse the repository at this point in the history
### Problem

Currently, strict_deps field in java_thrift_target will not be copied to the generated synthetic target.

### Solution

add 'strict_deps' into target attributes list to be copied.
  • Loading branch information
JieGhost committed Mar 10, 2017
1 parent bd01a9a commit 9f2d984
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Expand Up @@ -282,4 +282,4 @@ def _resolved_dep_info(self):

@property
def _copy_target_attributes(self):
return ['provides']
return ['provides', 'strict_deps']
Expand Up @@ -110,7 +110,8 @@ def _test_help(self, language, rpc_style, library_type, sources):
dependencies=[],
compiler='scrooge',
language='{language}',
rpc_style='{rpc_style}'
rpc_style='{rpc_style}',
strict_deps=True,
)
'''.format(language=language, rpc_style=rpc_style))

Expand Down Expand Up @@ -141,6 +142,7 @@ def _test_help(self, language, rpc_style, library_type, sources):
self.assertEquals(call_kwargs['provides'], None)
self.assertEquals(call_kwargs['sources'], [])
self.assertEquals(call_kwargs['derived_from'], target)
self.assertEquals(call_kwargs['strict_deps'], True)

finally:
Context.add_new_target = saved_add_new_target

0 comments on commit 9f2d984

Please sign in to comment.