From 9f2d984c2b474f4316375009ad920470b69f5a87 Mon Sep 17 00:00:00 2001 From: JieGhost Date: Fri, 10 Mar 2017 10:25:59 -0500 Subject: [PATCH] scrooge_gen task copy strict_deps field (#4321) ### Problem Currently, strict_deps field in java_thrift_target will not be copied to the generated synthetic target. ### Solution add 'strict_deps' into target attributes list to be copied. --- .../src/python/pants/contrib/scrooge/tasks/scrooge_gen.py | 2 +- .../pants_test/contrib/scrooge/tasks/test_scrooge_gen.py | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py b/contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py index a4b6cb637d0..99914dd13ac 100644 --- a/contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py +++ b/contrib/scrooge/src/python/pants/contrib/scrooge/tasks/scrooge_gen.py @@ -282,4 +282,4 @@ def _resolved_dep_info(self): @property def _copy_target_attributes(self): - return ['provides'] + return ['provides', 'strict_deps'] diff --git a/contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py b/contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py index c36079883ca..75a3d16d36e 100644 --- a/contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py +++ b/contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_scrooge_gen.py @@ -110,7 +110,8 @@ def _test_help(self, language, rpc_style, library_type, sources): dependencies=[], compiler='scrooge', language='{language}', - rpc_style='{rpc_style}' + rpc_style='{rpc_style}', + strict_deps=True, ) '''.format(language=language, rpc_style=rpc_style)) @@ -141,6 +142,7 @@ def _test_help(self, language, rpc_style, library_type, sources): self.assertEquals(call_kwargs['provides'], None) self.assertEquals(call_kwargs['sources'], []) self.assertEquals(call_kwargs['derived_from'], target) + self.assertEquals(call_kwargs['strict_deps'], True) finally: Context.add_new_target = saved_add_new_target