Skip to content
Permalink
Browse files

Bump to latest zinc in order to consume zinc analysis fix (#7854)

### Problem

We need to release #7853, which fixes #7850.

### Solution

Bump to the version built in #7853, and modify a test to confirm that it is fixed.
  • Loading branch information...
stuhood committed Jun 6, 2019
1 parent 256b696 commit ab179a265070a25ec3a30b6f886af38efcaafd84
@@ -32,9 +32,7 @@
from pants.util.memo import memoized_method, memoized_property


# TODO: To use this with the nailgun strategy, will need a publish of `rsc_2.12`: this will
# block landing this.
_ZINC_COMPILER_VERSION = '0.0.11'
_ZINC_COMPILER_VERSION = '0.0.12'


class Zinc(object):
@@ -129,7 +127,7 @@ def register_options(cls, register):
cls.register_jvm_tool(register,
Zinc.ZINC_EXTRACTOR_TOOL_NAME,
classpath=[
JarDependency('org.pantsbuild', 'zinc-extractor_2.12', '0.0.11')
JarDependency('org.pantsbuild', 'zinc-extractor_2.12', '0.0.12')
])

# Register scalac for fixed versions of Scala, 2.10, 2.11 and 2.12.
@@ -79,5 +79,6 @@ def test_no_summary_works(self):
target = 'testprojects/src/java/org/pantsbuild/testproject/unicode/main'
with self.temporary_cachedir() as cachedir, \
self.temporary_workdir() as workdir:
self._run_dep_usage(workdir, target, clean_all=True, cachedir=cachedir,
extra_args=['--no-dep-usage-jvm-summary'])
for compiler in ['rsc', 'zinc']:
self._run_dep_usage(workdir, target, clean_all=True, cachedir=cachedir,
extra_args=['--no-dep-usage-jvm-summary', '--jvm-platform-compiler={}'.format(compiler)])

0 comments on commit ab179a2

Please sign in to comment.
You can’t perform that action at this time.