From e543e339593a7978562417e536cba14af94f0389 Mon Sep 17 00:00:00 2001 From: Stu Hood Date: Fri, 31 Jul 2020 08:44:19 -0700 Subject: [PATCH] Remove rust source include from integration tests. (#10522) ### Problem Integration tests depend transitively on the `native_engine.so`, which is continuously validated because it must be present to run, and which is bootstrapped before pants starts up. But integration tests were also including the rust sources unnecessarily. ### Solution Remove the dependency on the rust sources, and the associated target. Also, align the comment about our use of `pants_local_binary` to what we learned in #10279. [ci skip-rust] [ci skip-build-wheels] --- src/python/pants/testutil/BUILD | 7 ++----- src/rust/engine/BUILD | 10 ---------- 2 files changed, 2 insertions(+), 15 deletions(-) delete mode 100644 src/rust/engine/BUILD diff --git a/src/python/pants/testutil/BUILD b/src/python/pants/testutil/BUILD index f1793d37e84..4ac041d44c6 100644 --- a/src/python/pants/testutil/BUILD +++ b/src/python/pants/testutil/BUILD @@ -37,12 +37,9 @@ target( name = 'int-test', dependencies=[ ':int-test-for-export', - # NB: 'pants_run_integration_test.py' runs ./pants in a subprocess, so test results will depend - # on the pants binary and all of its transitive dependencies. Adding the dependencies below is - # our best proxy for ensuring that any test target depending on this target will be invalidated - # on changes to those undeclared dependencies. + # NB: 'pants_run_integration_test.py' runs ./pants in a subprocess using the PYTHONPATH + # of the testrunner. We include the pants binary itself to fully populate the path. 'src/python/pants/bin:pants_local_binary', - 'src/rust/engine', ], ) diff --git a/src/rust/engine/BUILD b/src/rust/engine/BUILD deleted file mode 100644 index 721d8d82bd0..00000000000 --- a/src/rust/engine/BUILD +++ /dev/null @@ -1,10 +0,0 @@ -# Copyright 2018 Pants project contributors (see CONTRIBUTORS.md). -# Licensed under the Apache License, Version 2.0 (see LICENSE). - -# Track files depended on to build the native engine to allow for downstream invalidations. -files( - sources=["**/Cargo.*", "**/*.rs", "!**/target/*", "!process_execution/bazel_protos"], - dependencies=[ - 'src/rust/engine/process_execution/bazel_protos' - ] -)