New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new -parallel-methods flag is not compatible with the @TestSerial annotation #3209

Closed
ericzundel opened this Issue Apr 16, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@ericzundel
Copy link
Member

ericzundel commented Apr 16, 2016

The @TestSerial annotation is not respected when the -parallel-methods flag is in use. There is a test case for this marked with @pytest.fail in test_junit_tests_concurrency_integration.py in an upcoming PR.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 16, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 16, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 16, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 17, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 17, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 17, 2016

Add support for a command line flag to turn on parallel tests in meth…
…ods.

  - Adds a 'concurrency' and 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-parallel-methods to turn this feature on for all tests.
  - Adds Unit testing in ConsoleRunner test for the @TestParallel, @TestSerial annotations.
  - Adds integration testing for the above flags and annotations.

Note that there is a bug in that the @TestSerial annotation is not respected when
the -parallel-methods flag is in use.  See pantsbuild#3209

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 20, 2016

Enhance parallel testing junit_tests
Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
 - Adds a 'concurrency' parameter to set test concurrency to 'serial' 'parallel', or 'parallel_method'
 - Adds a 'threads' parameter to junit_tests to control concurrency.
 - Adds a --test-junit-parallel-methods to allow methods to run in parallel for the entire test run
 - Added a number of unit test cases and integration tests to exercise these features

Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
pass concurrency options to the junit-runner backend.

Testing Done:
Integration test and additional unit tests added.
CI is green at https://travis-ci.org/pantsbuild/pants/builds/123712609

Bugs closed: 3191, 3210

Reviewed at https://rbcommons.com/s/twitter/r/3707/

ericzundel added a commit that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
 - Adds a 'concurrency' parameter to set test concurrency to 'serial' 'parallel', or 'parallel_method'
 - Adds a 'threads' parameter to junit_tests to control concurrency.
 - Adds a --test-junit-parallel-methods to allow methods to run in parallel for the entire test run
 - Added a number of unit test cases and integration tests to exercise these features

Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See #3209

Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
pass concurrency options to the junit-runner backend.

Testing Done:
Integration test and additional unit tests added.
CI is green at https://travis-ci.org/pantsbuild/pants/builds/123712609

Bugs closed: 3191, 3210

Reviewed at https://rbcommons.com/s/twitter/r/3707/

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'serial' 'parallel', or 'parallel_method'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-parallel-methods to allow methods to run in parallel for the entire test run
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'serial' 'parallel', or 'parallel_method'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-parallel-methods to allow methods to run in parallel for the entire test run
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-parallel-methods to allow methods to run in parallel for the entire test run
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-default-concurrency option
     - PARALLEL_BOTH will allow both classes and methods to run in parallel for the entire test run
     - PARALLEL_METHODS (just run methods within a class in parallel) is flagged as not implemented
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 24, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-default-concurrency option
     - PARALLEL_BOTH will allow both classes and methods to run in parallel for the entire test run
     - PARALLEL_METHODS (just run methods within a class in parallel) is flagged as not implemented
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 26, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-default-concurrency option
     - PARALLEL_BOTH will allow both classes and methods to run in parallel for the entire test run
     - PARALLEL_METHODS (just run methods within a class in parallel) is flagged as not implemented
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit to ericzundel/pants that referenced this issue Apr 26, 2016

Enhance parallel testing junit_tests
    Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
     - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
     - Adds a 'threads' parameter to junit_tests to control concurrency.
     - Adds a --test-junit-default-concurrency option
     - PARALLEL_BOTH will allow both classes and methods to run in parallel for the entire test run
     - PARALLEL_METHODS (just run methods within a class in parallel) is flagged as not implemented
     - Added a number of unit test cases and integration tests to exercise these features

    Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See pantsbuild#3209

    Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
    pass concurrency options to the junit-runner backend.

ericzundel added a commit that referenced this issue Apr 26, 2016

Enhance parallel testing junit_tests
Surfaces EXPERIMENTAL support for parallel testing of methods within a test class.
  - Adds a 'concurrency' parameter to set test concurrency to 'SERIAL' 'PARALLEL_CLASSES', 'PARALLEL_METHODS', or 'PARALLEL_BOTH'
  - Adds a 'threads' parameter to junit_tests to control concurrency.
  - Adds a --test-junit-default-concurrency option
  - PARALLEL_BOTH will allow both classes and methods to run in parallel for the entire test run
  - PARALLEL_METHODS (just run methods within a class in parallel) is flagged as not implemented
  - Added a number of unit test cases and integration tests to exercise these features

Note that there is a bug in that the @TestSerial annotation is not respected when the -parallel-methods flag is in use.  See #3209

Followup work for this change is to add an `@TestParallelMethods` annotation and come up with a more rational way to
pass concurrency options to the junit-runner backend.

Testing Done:
Integration test and additional unit tests added.
CI is green at https://travis-ci.org/pantsbuild/pants/builds/125429738

Bugs closed: 3191, 3210, 3262

Reviewed at https://rbcommons.com/s/twitter/r/3707/
@ericzundel

This comment has been minimized.

Copy link
Member

ericzundel commented Jul 12, 2016

It is compatible now (if you use --use-experimental-runner)

@ericzundel ericzundel closed this Jul 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment