New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to packaging.version for pants versioning and switch away from `pre` convention #3382

Closed
stuhood opened this Issue May 10, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@stuhood
Member

stuhood commented May 10, 2016

According to semver 2.0.0 item 9:
Pre-release versions have a lower precedence than the associated normal version.

This is not currently the case for Revision:

>>> Revision.semver('1.1.1') < Revision.semver('1.1.1-pre0')
True

@stuhood stuhood added the bug label May 10, 2016

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood May 10, 2016

Member

As pointed out in hipchat, pants should be using pepxxx methods to version itself:

$ pex packaging
Python 2.7.10 (default, Dec 16 2015, 14:09:45) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from packaging.version import Version
>>> Version('1.1.1') < Version('1.1.1-pre0')
False
Member

stuhood commented May 10, 2016

As pointed out in hipchat, pants should be using pepxxx methods to version itself:

$ pex packaging
Python 2.7.10 (default, Dec 16 2015, 14:09:45) 
[GCC 4.2.1 Compatible Apple LLVM 7.0.2 (clang-700.1.81)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> from packaging.version import Version
>>> Version('1.1.1') < Version('1.1.1-pre0')
False

@stuhood stuhood added the 1.0.0 label May 18, 2016

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood May 18, 2016

Member

Moved this to the 1.0.0 label as post-1.0 work. Will work on the cluster of issues there.

Member

stuhood commented May 18, 2016

Moved this to the 1.0.0 label as post-1.0 work. Will work on the cluster of issues there.

@stuhood stuhood changed the title from Revision orders pre-release versions before stable releases to Switch to packaging.version for pants versioning and switch away from `pre` convention Jul 6, 2016

@digwanderlust

This comment has been minimized.

Show comment
Hide comment
@digwanderlust

digwanderlust Jul 18, 2016

Member

verified that this works without the dashes as well.

Member

digwanderlust commented Jul 18, 2016

verified that this works without the dashes as well.

@digwanderlust

This comment has been minimized.

Show comment
Hide comment
@digwanderlust

digwanderlust Sep 1, 2016

Member

Merged changes to packaging vs semver:

commit 69fcf06

Member

digwanderlust commented Sep 1, 2016

Merged changes to packaging vs semver:

commit 69fcf06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment