New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`NodeRun` does not thread its arguments down to the script #3453

Closed
patricklaw opened this Issue May 16, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@patricklaw
Copy link
Member

patricklaw commented May 16, 2016

npm expects passthrough args to come after --, but we are simply passing them straight to npm run right now.

@chrispesto

This comment has been minimized.

Copy link
Contributor

chrispesto commented May 18, 2016

Being done under the diff for #3407

stuhood added a commit that referenced this issue May 19, 2016

Make NodeTest task use the TestRunnerTaskMixin
This lets NodeTest targets time out if they take too long.

Also addressing #3453 - adding the "--" to NodeTest and NodeRun to pass their passthru arguments correctly to NPM.

Bugs closed: 3407

Reviewed at https://rbcommons.com/s/twitter/r/3870/
@chrispesto

This comment has been minimized.

Copy link
Contributor

chrispesto commented May 19, 2016

Fixed with: #3407

@patricklaw patricklaw closed this Jun 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment