New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile.zinc should reify the `-encoding` flags #3702

Open
stuhood opened this Issue Jul 20, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@stuhood
Member

stuhood commented Jul 20, 2016

scalac and javac independently accept an -encoding flag to set the encoding for compilation. A properly configured repo will thus always set both to something stable:

[compile.zinc]
args: [
    '-S-encoding', '-SUTF-8',
    '-C-encoding', '-CUTF-8',
  ]

We should reify this into a compile.zinc setting. Unfortunately, rolling it out will be... interesting.

@stuhood stuhood added the jvm label Jul 20, 2016

stuhood added a commit that referenced this issue Jul 20, 2016

Set the encoding for javac in pantsbuild/pants
Without an encoding explicitly set, javac's encoding will float to whatever the environment has it set to. See #3702 for more info on what we should do to fix this more thoroughly.

- Set the encoding for javac, and refer to a ticket about reifying the setting.

Testing Done:
https://travis-ci.org/pantsbuild/pants/builds/146201334
http://jenkins.pantsbuild.org/job/pantsbuild/job/pants/job/PR-3703/

Bugs closed: 3691, 3702, 3703

Reviewed at https://rbcommons.com/s/twitter/r/4103/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment