New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[engine] strategy for interrupting engine execution to support user-driven interrupts #5285
Comments
mod any potential concerns wrt partial request computation, on the surface this seems like approximately:
|
I think this sounds reasonable. One adjustment would be necessary: Currently the main thread is the one actually doing the work by calling |
Related: rust-lang/futures-rs#696 |
An update: it is no longer the case that the main thread is the one doing the work here. We've switched to launching all work on the tokio runtime, and so it should be the case that the main thread is able to wait in a loop and die for signals. |
A first potential commit in this direction is here: master...twitter:stuhood/dont-block-the-main-thread Will look into @kwlzn's suggestions about the kill switch on Monday. |
This has been fixed since we began respecting signals in the UI loop a while back. |
in order to support a saner fix for #5220, it seems like we'll want to have some way to gracefully interrupt an in-flight engine execution that can be called from a python signal handler in the daemon.
The text was updated successfully, but these errors were encountered: