New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExecuteProcessRequest gives bad output directory if a file matches both output_files and output_directories #6558

Closed
illicitonion opened this Issue Sep 26, 2018 · 0 comments

Comments

Projects
1 participant
@illicitonion
Copy link
Contributor

illicitonion commented Sep 26, 2018

If you run:

ExecuteProcessRequest(
  argv=("/bin/bash", "-c", "/bin/mkdir dir && /usr/bin/touch dir/file"),
  output_files=("dir/file",),
  output_directories=("dir",),
)

you will end up with an output directory which contains dir/file as an empty directory.

This is bad.

@illicitonion illicitonion added this to To do in Remoting via automation Sep 26, 2018

illicitonion added a commit to twitter/pants that referenced this issue Sep 26, 2018

Fix up execution:
* Include bootstrapper in input snapshot
* Don't capture output twice (pantsbuild#6558)

illicitonion added a commit that referenced this issue Sep 26, 2018

Relativise paths (#6553)
* Relativise paths
* Include bootstrapper in input snapshot
* Don't capture output twice (#6558)

illicitonion added a commit that referenced this issue Sep 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment