Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rsc-compile] break out java metacping into a separate job #6754

Closed
baroquebobcat opened this issue Nov 9, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@baroquebobcat
Copy link
Contributor

commented Nov 9, 2018

Currently java targets are metacp'd as part of building each scala target. It would be better to metacp them once per java target.

There's a couple approaches here

  1. create a new Job that
  • depends on java zinc compiles
  • is depended on by rsc scala compiles
  • runs metacp on the result of a java zinc compile
  1. wrap the existing java zinc work fn with a fn that runs metacp after invoking the zinc compile. This doesn't require any network changes.

This is very similar to 2be0b1d#diff-074dd871ff62c835ab90d4a0a1264a63

I haven't spent much time refactoring this, so there is a lot of duplication.

@stuhood

This comment has been minimized.

Copy link
Member

commented Nov 27, 2018

Thank you @baroquebobcat... will tackle this this/next week.

@stuhood stuhood self-assigned this Nov 27, 2018

@stuhood stuhood removed their assignment Dec 11, 2018

@stuhood

This comment has been minimized.

Copy link
Member

commented Dec 11, 2018

Argh... sorry. I left this too long, and now looking at it more deeply, I definitely will not be able to complete it in time.

I am definitely, definitely left feeling that we should invest in #6898 or #6856 in order to unblock porting this code to @rules.

@stuhood stuhood closed this in #6940 Jan 2, 2019

stuhood added a commit that referenced this issue Jan 2, 2019

When compiling with rsc, metacp java libraries in a separate executio…
…n graph node. (#6940)

### Problem

As described in #6754: Currently java targets are metacp'd as part of building each scala target. It would be better to metacp them once per java target.

### Solution

Rename `work_for_vts_rsc_jar_library` to `work_for_vts_metacp`, and reuse it for metacp'ing java libraries after compilation.

### Result

Fixes #6754.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.