TestPailgunServer.test_process_request_error is flaky

[stuhood]

__ TestPailgunServer.test_process_request_error __
 
 self = <pants_test.pantsd.test_pailgun_server.TestPailgunServer testMethod=test_process_request_error>
 mock_shutdown_request = <function shutdown_request at 0x7fe39f1f0140>
 
     @mock.patch.object(PailgunServer, 'shutdown_request', **PATCH_OPTS)
     def test_process_request_error(self, mock_shutdown_request):
       mock_request = mock.Mock()
       self.mock_handler_inst.handle_request.side_effect = AttributeError('oops')
       self.server.process_request(mock_request, ('1.2.3.4', 31338))
 >     self.assertIs(self.mock_handler_inst.handle_request.called, True)
 E     AssertionError: False is not True
 
 pants_test/pantsd/test_pailgun_server.py:64: AssertionError

[jsirois]

I hit this. A quick look says this test - and others in the same class - are doomed to failure. They exercise self.server.process_request which is a method that spawns a thread with no joining or latching or ... so the thing depends on the spawned thread beating the assert.