Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert ~all of the ctypes integration tests to unit tests in the native backend #7128

Open
cosmicexplorer opened this issue Jan 23, 2019 · 0 comments

Comments

1 participant
@cosmicexplorer
Copy link
Contributor

commented Jan 23, 2019

Most of the tests in test_ctypes_integration.py are flaky (see #6886) or at best extremely slow (sorry about that!!! won't happen again). In #7126 we convert almost all of the python_dist() integration tests into unit tests, which also removes > 500 lines of code. After some practice with task unit testing in that PR, it's extremely clear that we should do the same with ctypes (this wasn't done in #7126 because it was already big enough).

We should also make sure to whittle down the dependencies in the ctypes test targets, as they were copied verbatim from tests/python/pants_test/backend/python/tasks/BUILD to ease the transition from supporting use of the native toolchain for compiling distutils Extensions (which was EOLed in #7126).

cosmicexplorer added a commit that referenced this issue Mar 3, 2019

move the declarative task stuff out of the python backend testing (#7279
)

### Problem

We want to do #7128, which involves adding some more C/C++ unit testing. We would love to use some of the declarative task specification stuff we've added to the `python_dist()` testing to do that.

### Solution

- Move the generic logic out of `BuildLocalPythonDistributionsTestBase` into `DeclarativeTaskTestMixin` in `task_test_base.py`.

### Result

A new interface for task unit testing (which can be extended to more than just v1 tasks) is available to other testing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.