Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote::tests::getoperation_response_error is flaky #7228

Closed
cosmicexplorer opened this Issue Feb 7, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@cosmicexplorer
Copy link
Contributor

cosmicexplorer commented Feb 7, 2019

I think but cannot be sure that this has reproed locally, so I suspect it is not a network error. Not a lot of information here.

thread 'remote::tests::getoperation_response_error' panicked at 'assertion failed: `(left == right)`
  left: `"Error { kind: Inner(Error { kind: Proto(PROTOCOL_ERROR) }) }"`,
 right: `"INTERNAL: Something went wrong"`', process_execution/src/remote.rs:1709:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:491
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: process_execution::remote::tests::getoperation_response_error
             at process_execution/src/remote.rs:1709
   8: process_execution::remote::tests::getoperation_response_error::{{closure}}
             at process_execution/src/remote.rs:1678
   9: core::ops::function::FnOnce::call_once
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/ops/function.rs:238
  10: <F as alloc::boxed::FnBox<A>>::call_box
             at src/libtest/lib.rs:1471
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/ops/function.rs:238
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/liballoc/boxed.rs:673
  11: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
@cosmicexplorer

This comment has been minimized.

Copy link
Contributor Author

cosmicexplorer commented Feb 13, 2019

add getoperation_missing_response_and_error to the list (https://travis-ci.org/pantsbuild/pants/jobs/492456319):

thread 'remote::tests::getoperation_missing_response_and_error' panicked at 'assertion failed: `(left == right)`
  left: `"Error { kind: Inner(Error { kind: Proto(PROTOCOL_ERROR) }) }"`,
 right: `"Operation finished but no response supplied"`', process_execution/src/remote.rs:1766:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
stack backtrace:
   0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace
             at src/libstd/sys/unix/backtrace/tracing/gcc_s.rs:49
   1: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:71
   2: std::panicking::default_hook::{{closure}}
             at src/libstd/sys_common/backtrace.rs:59
             at src/libstd/panicking.rs:211
   3: std::panicking::default_hook
             at src/libstd/panicking.rs:227
   4: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:491
   5: std::panicking::continue_panic_fmt
             at src/libstd/panicking.rs:398
   6: std::panicking::begin_panic_fmt
             at src/libstd/panicking.rs:353
   7: process_execution::remote::tests::getoperation_missing_response_and_error
             at process_execution/src/remote.rs:1766
   8: process_execution::remote::tests::getoperation_missing_response_and_error::{{closure}}
             at process_execution/src/remote.rs:1741
   9: core::ops::function::FnOnce::call_once
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/ops/function.rs:238
  10: <F as alloc::boxed::FnBox<A>>::call_box
             at src/libtest/lib.rs:1471
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/libcore/ops/function.rs:238
             at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/liballoc/boxed.rs:673
  11: __rust_maybe_catch_panic
             at src/libpanic_unwind/lib.rs:102
test remote::tests::getoperation_missing_response_and_error ... FAILED
@illicitonion

This comment has been minimized.

Copy link
Contributor

illicitonion commented Feb 19, 2019

Fixed by stopping using Tower in #7256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.