Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
[pantsd] Ctrl-C isn't forwarded properly when a pailun request is waiting for another one to finish #7920
Currently, we don't send the PID and PGRP chunks through Nailgun until a
This leads to behaviour like this, because the client relies on knowing the pid of the pantsd process when forwarding SIGINT to the daemon.
The problem we want to solve is how to stop a pants run that is waiting for another one to finish, without crashing the daemon.
The more I think about it the more it seems that using signals is not going to work for per-request cancellation, and we need a Nailgun-based solution. The approach that seems most feasible to me is to have another socket that the client can use to send messages to the server (or the same socket if bidirectional communication is possible), and to wrap the thread that is handling a request in another thread that reads messages from the client and stops the request being served when the client sends
Yeah, totally agreed.…
On Fri, 21 Jun 2019, 16:52 Danny McClanahan, ***@***.***> wrote: We can probably just have the client die here, I think, without forwarding any signals! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#7920?email_source=notifications&email_token=ABMW6PXZO6H3KMJ2LTTUOT3P3T2KFA5CNFSM4H2QDG72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYI3CGI#issuecomment-504475929>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMW6PT76TKQCYK7FRGI2M3P3T2KFANCNFSM4H2QDG7Q> .