Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sdist wheels fail to build with remote execution #8057

Closed
Eric-Arellano opened this issue Jul 16, 2019 · 0 comments

Comments

@Eric-Arellano
Copy link
Contributor

commented Jul 16, 2019

Likely this is because we hardcode CPPFLAGS and LDFLAGS to override the host defaults:

pants/pants.remote.ini

Lines 38 to 40 in 1a8e69f

[python-native-code]
ld_flags: []
cpp_flags: []

To test, run ./pants --pants-config-files=pants.remote.ini --no-v1 --v2 --remote-oauth-bearer-token-path=<(gcloud auth application-default print-access-token | perl -p -e 'chomp if eof') test tests/python/pants_test/auth:auth.

@Eric-Arellano Eric-Arellano self-assigned this Jul 16, 2019

stuhood added a commit that referenced this issue Jul 17, 2019

Extend Google RBE Docker image to allow building sdist wheels (#8059)
Google's Ubuntu image does not have the dependencies necessary to install `psutil`, `scandir`, `pyopenssl`, `setproctitle`, and `python-Levenshtein`, as documented in #8057.

Turns out, all that's necessary to fix this is installing `build-essential`. The fix was confirmed locally by building this image then running `docker run -t remote_execution sh -c 'pip3 install pex; pex setproctitle scandir psutil python-Levenshtein'`.

Will close #8057.

Eric-Arellano added a commit that referenced this issue Jul 18, 2019

Use our docker image from #8059 for remote execution (#8068)
This actually fixes #8057 by using the image created in #8059.

sammy-1234 pushed a commit to sammy-1234/pants that referenced this issue Jul 18, 2019

Extend Google RBE Docker image to allow building sdist wheels (pantsb…
…uild#8059)

Google's Ubuntu image does not have the dependencies necessary to install `psutil`, `scandir`, `pyopenssl`, `setproctitle`, and `python-Levenshtein`, as documented in pantsbuild#8057.

Turns out, all that's necessary to fix this is installing `build-essential`. The fix was confirmed locally by building this image then running `docker run -t remote_execution sh -c 'pip3 install pex; pex setproctitle scandir psutil python-Levenshtein'`.

Will close pantsbuild#8057.

sammy-1234 pushed a commit to sammy-1234/pants that referenced this issue Jul 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.