Setup logging before plugins are loaded. #1158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lifts logging options to the bootstrap stage in order to be able to configure logging before plugins are loaded. The logging setup is lifted out from GoalRunner to a top-level function in the logging package and tests are added for logging configuration. Additionally, bootstrap option parsing is fixed to handle short flags since logging uses a few of these.
1 similar comment
Document the difference between bootstrap and global options. Explicitly enable the 'WARN' alias for logging at 'WARNING' level. Fix a bug where passthrough options with the same name as bootstrap options would be bootstrapped.
…rois/logging/early_setup
1 similar comment
|
Submitted @ c0de6c4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lifts logging options to the bootstrap stage in order to be able
to configure logging before plugins are loaded. The logging setup is
lifted out from GoalRunner to a top-level function in the logging
package and tests are added for logging configuration.
Additionally, bootstrap option parsing is fixed to handle short flags
since logging uses a few of these.
https://rbcommons.com/s/twitter/r/1820/