Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Use chevron instead of pystache to fix broken release process #13528

Merged
merged 4 commits into from Nov 8, 2021

Conversation

asherf
Copy link
Member

@asherf asherf commented Nov 8, 2021

since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt

Copy link
Sponsor Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing that this was so easy to do. Thanks!!

build-support/bin/BUILD Outdated Show resolved Hide resolved
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano changed the title Switch to to use chevron instead of pystache to generate pants docs [internal] Use chevron instead of pystache to generate pants docs Nov 8, 2021
@Eric-Arellano Eric-Arellano changed the title [internal] Use chevron instead of pystache to generate pants docs [internal] Use chevron instead of pystache to fix broken release Nov 8, 2021
@Eric-Arellano Eric-Arellano changed the title [internal] Use chevron instead of pystache to fix broken release [internal] Use chevron instead of pystache to fix broken release process Nov 8, 2021
# Rust tests and lints will be skipped. Delete if not intended.
[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
@Eric-Arellano Eric-Arellano merged commit f70cb25 into pantsbuild:main Nov 8, 2021
@asherf asherf deleted the chevron branch November 8, 2021 19:15
Eric-Arellano pushed a commit to Eric-Arellano/pants that referenced this pull request Nov 8, 2021
…ess (Cherry-pick of pantsbuild#13528)

since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt

[ci skip-rust]

# Building wheels and fs_util will be skipped. Delete if not intended.
[ci skip-build-wheels]
Eric-Arellano added a commit that referenced this pull request Nov 8, 2021
…ess (Cherry-pick of #13528) (#13535)

since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt

[ci skip-rust]
[ci skip-build-wheels]
stuhood pushed a commit to stuhood/pants that referenced this pull request Nov 10, 2021
…ess (Cherry-pick of pantsbuild#13528) (pantsbuild#13535)

since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt

[ci skip-rust]
[ci skip-build-wheels]
stuhood added a commit that referenced this pull request Nov 10, 2021
…ess (Cherry-pick of #13528) (#13535) (#13562)

since pystache hasn't been updated since 2014.
also opted to have the chevron req specified in the single place we need it instead of in the somewhat global requirements.txt

[ci skip-rust]
[ci skip-build-wheels]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants