[jvm] Hook up the ability to run JUnit tests written in Scala #13868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rceField for junit test files. [ci skip-rust]
[ci skip-rust]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust]
stuhood
changed the title
| # ----------------------------------------------------------------------------------------------- | ||
|
|
||
|
|
||
| class JunitTestSourceField(SingleSourceField, metaclass=ABCMeta): |
There was a problem hiding this comment.
It's confusing imo for this to subclass SingleSourceField and then for the subclasses of this to also subclass JavaSourceField and ScalaSourceField. it works, but confusing.
Instead, I recommend calling this JunitTestSourceMixin, and it's nothing more than a marker type. Doesn't subclass anything, not even ABCMeta.
There was a problem hiding this comment.
That won't work I don't think: this does actually need to be a SourcesField subclass, because it is used with a FieldSet.
Comment on lines
-146
to
-152
| class JvmRequirementsField(SpecialCasedDependencies): | ||
| alias = "requirements" | ||
| required = True | ||
| help = ( | ||
| "A sequence of addresses to targets compatible with `jvm_artifact` that specify the coordinates for " | ||
| "third-party JVM dependencies." | ||
| ) |
There was a problem hiding this comment.
Thanks, I was about to delete this :)
Eric-Arellano
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scala_junit_teststarget was added in #13130, and became compilable from the JUnit@rulesin #13519. The final piece to enable actual usage is to allow the JUnit@rulesto match non-Java sources.This change adds the
JunitTestSourceFieldmarker, which is extended byJavaJunitTestSourceFieldandScalaJunitTestSourceField, and tests that JUnit tests can be written in Scala.[ci skip-rust]