Add ssh field to docker_image.
#13957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Dec 23, 2021
| default = () | ||
| help = ( | ||
| "SSH agent socket or keys to expose to the build (only if BuildKit enabled) " | ||
| "(format: default|<id>[=<socket>|<key>[,<key>]])\n\n" |
There was a problem hiding this comment.
Thanks for specifying the grammar! Perhaps an example would help too in a followup paragraph? I appreciate the example with RUN --mount=type=ssh.
There was a problem hiding this comment.
Not blocking. My brain works better seeing examples, but the help message is already quite excellent :)
There was a problem hiding this comment.
Yeah, the lack of example here is mainly due to me not having a clue! :P :D
Never used this option myself, so it's just copy paste from the docker docs. ;)
There was a problem hiding this comment.
I'll land this as-is for now. we can always come back and improve on it later..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13935