Add Protobuf formatting using buf format - #14907
Merged
Merged
Conversation
Eric-Arellano
previously approved these changes
Mar 25, 2022
Eric-Arellano
left a comment
Eric-Arellano
left a comment
Contributor
There was a problem hiding this comment.
This is super exciting!
Eric-Arellano
dismissed
their stale review
March 25, 2022 05:33
Oops, didn't mean to hit approve. Looks good other than name being ambiguous
Member
Author
|
Buf added an |
Eric-Arellano
left a comment
Eric-Arellano
left a comment
Contributor
There was a problem hiding this comment.
Looks great - will approve & merge once the naming weirdness is finalized
Eric-Arellano
approved these changes
Mar 25, 2022
Contributor
|
cc @thejcannon - this will conflict with your very exciting PR at #14903, but I'd like to merge this one first so that we can cherry-pick to 2.11 (and less churn for Jonas) |
Eric-Arellano
approved these changes
Mar 25, 2022
jyggen
added a commit
to jyggen/pants
that referenced
this pull request
Mar 25, 2022
This PR adds support for Protobuf formatting using the newly released `buf format`. I took the libery of bumping the default version of `buf`since `buf format` requires Buf v1.2.0 and above. Right now there's no check to make sure the user is actually on >v1.2.0, but that shouldn't be too hard to add if needed.
Eric-Arellano
pushed a commit
that referenced
this pull request
Mar 25, 2022
) This PR adds support for Protobuf formatting using the newly released `buf format`. I took the libery of bumping the default version of `buf`since `buf format` requires Buf v1.2.0 and above. Right now there's no check to make sure the user is actually on >v1.2.0, but that shouldn't be too hard to add if needed. [ci skip-rust]
Eric-Arellano
pushed a commit
that referenced
this pull request
Mar 26, 2022
Some simple validation to make sure that two or more `LintTargetsRequest` don't use the same name which, based on #14907 (comment), can cause some havoc. I assume this can cause issues in most goals, so might be interesting to add to more places as well. [ci skip-rust] [ci skip-build-wheels]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Protobuf formatting using the newly released
buf format. I took the libery of bumping the default version ofbufsincebuf formatrequires Buf v1.2.0 and above. Right now there's no check to make sure the user is actually on >v1.2.0, but that shouldn't be too hard to add if needed.