Explicitly add directory entries to resources JARs (Cherry-pick of #16264) #16296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per @somdoron's discovery, resources JARs need directory entries in order to work correctly at runtime. This adds an entry for every directory that corresponds to a file in the set of resource files. Also includes a unit test that verifies that the directory entries are present. Closes pantsbuild#16231. [ci skip-rust] [ci skip-build-wheels]
Eric-Arellano
approved these changes
Jul 25, 2022
Per @somdoron's discovery, resources JARs need directory entries in order to work correctly at runtime. This adds an entry for every directory that corresponds to a file in the set of resource files. Also includes a unit test that verifies that the directory entries are present. Closes pantsbuild#16231. [ci skip-rust] (cherry picked from commit 6a27b46) # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @somdoron's discovery, resources JARs need directory entries in order to work correctly at runtime. This adds an entry for every directory that corresponds to a file in the set of resource files. Also includes a unit test that verifies that the directory entries are present.
Closes #16231.