Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand lockfile documentation to its own page. #18471

Merged
merged 2 commits into from Mar 11, 2023
Merged

Expand lockfile documentation to its own page. #18471

merged 2 commits into from Mar 11, 2023

Conversation

benjyw
Copy link
Sponsor Contributor

@benjyw benjyw commented Mar 11, 2023

In particular, document the new way of generating tool lockfiles.

@benjyw
Expand lockfile documentation to its own page.
5dc0c7f 
In particular, document the new way of generating
tool lockfiles.
@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Mar 11, 2023

You can see these rendered:

https://www.pantsbuild.org/v2.16/docs/python-lockfiles
https://www.pantsbuild.org/v2.16/docs/python-third-party-dependencies

kaos
kaos approved these changes Mar 11, 2023
View reviewed changes
Copy link
Member

@kaos kaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be a good place to also, if only in passing, mention the [generate-lockfiles].diff option..? :)

@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Mar 11, 2023

Wouldn't this be a good place to also, if only in passing, mention the [generate-lockfiles].diff option..? :)

Excellent idea!!

@benjyw
Copy link
Sponsor Contributor Author

benjyw commented Mar 11, 2023

PS I think we should switch the default from False to True? Why would someone not want these diffs?

@benjyw benjyw merged commit d898fdd into pantsbuild:main Mar 11, 2023
17 checks passed
@benjyw benjyw deleted the lockfile_docs branch March 11, 2023 18:01
benjyw added a commit to benjyw/pants that referenced this pull request Mar 11, 2023
@benjyw
Expand lockfile documentation to its own page. (pantsbuild#18471)
8fecef4 
In particular, document the new way of generating tool lockfiles.
benjyw added a commit that referenced this pull request Mar 11, 2023
@benjyw
Expand lockfile documentation to its own page. (cherrypick of #18471) (…
ab42f02 
…#18474)

In particular, document the new way of generating tool lockfiles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaos kaos kaos approved these changes

@jsirois jsirois jsirois approved these changes

@Eric-Arellano Eric-Arellano Awaiting requested review from Eric-Arellano

Assignees
No one assigned
Labels
category:documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benjyw @kaos @jsirois