Optimize python parsers. #2346
Closed
Optimize python parsers. #2346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fundamental restructuring is moving from Addressed values to a class-housed schema of addressable fields powered by a @property-like `AddressableDescriptor` with write-once semantics and that can contain `Resolvable` values in addition to opaque address strings and concrete values. This move reduces the memory requirements of parsing objects, they are now just an object with a single `_kwargs` dict of unadorned string address values in the addressable field case. With the `Resolvable` type plumbed into addressable schemas, both the json encoder and the Graph gain the ability to materialize or serialize shallow or inlined graphs bringing the testable space of the noun side of the experiment up to 3 parsers x 2 graph modes.
This is part of support for inter-operation with legacy BUILD files.
This restructures the two python parsers to return a parser that re-uses as much symbol table setup as possible across individual file parses.
|
More work towards #2308. In particular in this case more performant parsing in the legacy BUILD file ecosystem. |
|
This was split out of #2312 |
|
Submitted @ 24d8a16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restructures the two python parsers to return a parser that re-uses
as much symbol table setup as possible across individual file parses.
https://rbcommons.com/s/twitter/r/2947/