Convert readthedocs link for their .org -> .io migration for hosted projects #3542

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@adamchainz
Contributor

adamchainz commented Jun 2, 2016

As per their blog post of the 27th April ‘Securing subdomains’:

Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.

Convert readthedocs link for their .org -> .io migration for hosted p…
…rojects

As per [their blog post of the 27th April](https://blog.readthedocs.com/securing-subdomains/) ‘Securing subdomains’:

> Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.

Test Plan: Manually visited all the links I’ve modified.
@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Apr 18, 2017

Member

Sorry for the delay on this @adamchainz. Although the change is small a conflict has crept in in a block of code now removed with a readthedocs link in a comment. I'll try fixing that up, pushing here and merging your work.

Member

jsirois commented Apr 18, 2017

Sorry for the delay on this @adamchainz. Although the change is small a conflict has crept in in a block of code now removed with a readthedocs link in a comment. I'll try fixing that up, pushing here and merging your work.

@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Apr 18, 2017

Member

Conflict resolved and merged @ 226a1e1

Member

jsirois commented Apr 18, 2017

Conflict resolved and merged @ 226a1e1

@jsirois jsirois closed this Apr 18, 2017

@adamchainz

This comment has been minimized.

Show comment
Hide comment
@adamchainz

adamchainz Apr 18, 2017

Contributor

@jsirois thanks. btw your modification of the commit rearranged some imports, idk if that was on purpose?

Contributor

adamchainz commented Apr 18, 2017

@jsirois thanks. btw your modification of the commit rearranged some imports, idk if that was on purpose?

@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Apr 19, 2017

Member

It was. We have a precommit check that enforces sorted imports necessitating the correction. I did not dig into how the file had mis-sorted imports in the first place.

Member

jsirois commented Apr 19, 2017

It was. We have a precommit check that enforces sorted imports necessitating the correction. I did not dig into how the file had mis-sorted imports in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment