New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[engine] Skip re-creating copy of address if no variants #4032

Merged
merged 1 commit into from Apr 21, 2017

Conversation

Projects
None yet
2 participants
@baroquebobcat
Contributor

baroquebobcat commented Nov 5, 2016

The current parse_variants constructs a new address regardless of whether there were variants or not within the address. This adds a check that returns early if there was no at sign in the
target_name, ie that the split target_name is equal to the original.

[engine] Skip re-creating copy of address if no variants
The current parse_variants constructs a new address regardless of whether there were variants or not within the address. This adds a check that returns early if there was no at sign in the
target_name, ie that the split target_name is equal to the original.
@jsirois

This change still looks valid, not sure if you want to land it. If not, please close the PR - on a quest to kill all applied or obsolete PRs.

@baroquebobcat

This comment has been minimized.

Show comment
Hide comment
@baroquebobcat

baroquebobcat Apr 21, 2017

Contributor

Roger.

Contributor

baroquebobcat commented Apr 21, 2017

Roger.

@baroquebobcat baroquebobcat merged commit 238282d into pantsbuild:master Apr 21, 2017

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

[engine] Skip re-creating copy of address if no variants (#4032)
The current parse_variants constructs a new address regardless of whether there were variants or not within the address. This adds a check that returns early if there was no at sign in the
target_name, ie that the split target_name is equal to the original.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment