Spelling mistake in first_tutorial #4045

Merged
merged 1 commit into from Nov 18, 2016

Conversation

Projects
None yet
3 participants
@markdav
Contributor

markdav commented Nov 11, 2016

The internet grammar police tot he rescue. Not the most critical PR you'll ever merge.. but it makes a bad first impression of the tool.

@mateor

This comment has been minimized.

Show comment
Hide comment
@mateor

mateor Nov 16, 2016

Member

Hi Mark, thanks for taking the time to submit a patch!

Pants currently uses RBCommons for patch contributions and code review, and is the only way to land a patch.

I know it seems heavy weight considering the change, but it also powers the changelog construction and other tooling. Would you mind opening an RBCommons review? If you add me as a reviewer, I can land it for you from there.

It is possible you did this already and I just cannot find it. If so, apologies in advance :)

Member

mateor commented Nov 16, 2016

Hi Mark, thanks for taking the time to submit a patch!

Pants currently uses RBCommons for patch contributions and code review, and is the only way to land a patch.

I know it seems heavy weight considering the change, but it also powers the changelog construction and other tooling. Would you mind opening an RBCommons review? If you add me as a reviewer, I can land it for you from there.

It is possible you did this already and I just cannot find it. If so, apologies in advance :)

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Nov 18, 2016

Contributor

Update: as discussed at the summit, we're in the process of evaluating switching to doing code reviews on github directly. So no need for an RBCommons review in this case.

Contributor

benjyw commented Nov 18, 2016

Update: as discussed at the summit, we're in the process of evaluating switching to doing code reviews on github directly. So no need for an RBCommons review in this case.

@mateor

This comment has been minimized.

Show comment
Hide comment
@mateor

mateor Nov 18, 2016

Member

Hi again, Mark.

Turns out that we have finally pulled the trigger on moving to Github pulls. So I gave you bad info, as benjy just commented. I will land this today before our release.

Thanks for the contribution :)

Member

mateor commented Nov 18, 2016

Hi again, Mark.

Turns out that we have finally pulled the trigger on moving to Github pulls. So I gave you bad info, as benjy just commented. I will land this today before our release.

Thanks for the contribution :)

@mateor

mateor approved these changes Nov 18, 2016

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Nov 18, 2016

Contributor

Mateo - you can land this by doing a squash-merge on github.com, or simply
by locally merging and pushing.

On Fri, Nov 18, 2016 at 11:38 AM, Mateo Rodriguez notifications@github.com
wrote:

@mateor approved this pull request.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#4045 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfS_Poy0ORM-n5oRS10yxaA_MoTUBrGks5q_f64gaJpZM4Kv2eU
.

Contributor

benjyw commented Nov 18, 2016

Mateo - you can land this by doing a squash-merge on github.com, or simply
by locally merging and pushing.

On Fri, Nov 18, 2016 at 11:38 AM, Mateo Rodriguez notifications@github.com
wrote:

@mateor approved this pull request.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#4045 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfS_Poy0ORM-n5oRS10yxaA_MoTUBrGks5q_f64gaJpZM4Kv2eU
.

@markdav

This comment has been minimized.

Show comment
Hide comment
@markdav

markdav Nov 18, 2016

Contributor

Yay thanks for this.. now I'm officially a pants contributor! :)

On 18 Nov 2016 20:42, "Benjy Weinberger" notifications@github.com wrote:

Mateo - you can land this by doing a squash-merge on github.com, or simply
by locally merging and pushing.

On Fri, Nov 18, 2016 at 11:38 AM, Mateo Rodriguez <
notifications@github.com>
wrote:

@mateor approved this pull request.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4045 (review)
,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AAfS_Poy0ORM-n5oRS10yxaA_MoTUBrGks5q_f64gaJpZM4Kv2eU>
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4045 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFeahMlyQQcQkMjAhdBNXh9GdA3nUO82ks5q_g2ngaJpZM4Kv2eU
.

Contributor

markdav commented Nov 18, 2016

Yay thanks for this.. now I'm officially a pants contributor! :)

On 18 Nov 2016 20:42, "Benjy Weinberger" notifications@github.com wrote:

Mateo - you can land this by doing a squash-merge on github.com, or simply
by locally merging and pushing.

On Fri, Nov 18, 2016 at 11:38 AM, Mateo Rodriguez <
notifications@github.com>
wrote:

@mateor approved this pull request.


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4045 (review)
,
or mute the thread
<https://github.com/notifications/unsubscribe-
auth/AAfS_Poy0ORM-n5oRS10yxaA_MoTUBrGks5q_f64gaJpZM4Kv2eU>
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#4045 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFeahMlyQQcQkMjAhdBNXh9GdA3nUO82ks5q_g2ngaJpZM4Kv2eU
.

@mateor mateor merged commit 3d70ca5 into pantsbuild:master Nov 18, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mateor

This comment has been minimized.

Show comment
Hide comment
@mateor

mateor Nov 18, 2016

Member

Welcome :)

Member

mateor commented Nov 18, 2016

Welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment