Replace instances of pantsbuild.github.io in the docs with pantsbuild… #4074

Merged
merged 1 commit into from Nov 18, 2016

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Nov 18, 2016

….org.

@lahosken

Yay, thank you for doing this

@benjyw benjyw merged commit b9b920f into pantsbuild:master Nov 18, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:docfixes branch Nov 18, 2016

@mateor

This comment has been minimized.

Show comment
Hide comment
@mateor

mateor Nov 18, 2016

Member

Is this an approved way to merge doc changes? If so, I would use it to land: #4045

Seems fine to me, flipping the switch to "allowed" just must have snuck past me

Member

mateor commented Nov 18, 2016

Is this an approved way to merge doc changes? If so, I would use it to land: #4045

Seems fine to me, flipping the switch to "allowed" just must have snuck past me

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Nov 18, 2016

Contributor

We're looking to switch to github code reviews entirely, now that they
don't suck, so yes, this is a fine way to land #4045.

On Fri, Nov 18, 2016 at 11:30 AM, Mateo Rodriguez notifications@github.com
wrote:

Is this an approved way to merge doc changes? If so, I would use it to
land: #4045 #4045


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#4074 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfS_Bo7VO1gkn9bHs2KQruZQ9LX2TL3ks5q_fzagaJpZM4K2KSn
.

Contributor

benjyw commented Nov 18, 2016

We're looking to switch to github code reviews entirely, now that they
don't suck, so yes, this is a fine way to land #4045.

On Fri, Nov 18, 2016 at 11:30 AM, Mateo Rodriguez notifications@github.com
wrote:

Is this an approved way to merge doc changes? If so, I would use it to
land: #4045 #4045


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#4074 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAfS_Bo7VO1gkn9bHs2KQruZQ9LX2TL3ks5q_fzagaJpZM4K2KSn
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment