Move SimpleCodegenTask into the pants core. #4079

Merged
merged 1 commit into from Nov 20, 2016

Conversation

Projects
None yet
5 participants
@benjyw
Contributor

benjyw commented Nov 18, 2016

This allows us to do away with the 'codegen' backend,
in favor of a thrift backend, proto backend, etc.
The idea of a single global codegen backend makes no sense,
as they share almost no code.

The one part they do share, SimpleCodegenTask, is small,
self-contained, and represents a generic enough concept
that it can comfortably live in the core.

This change also modifies SimpleCodegenTask's test to not
rely on the codegen or JVM backends.

Move SimpleCodegenTask into the pants core.
This allows us to do away with the 'codegen' backend,
in favor of a thrift backend, proto backend, etc.
The idea of a single global codegen backend makes no sense,
as they share almost no code.

The one part they do share, SimpleCodegenTask, is small,
self-contained, and represents a generic enough concept
that it can comfortably live in the core.

This change also modifies SimpleCodegenTask's test to not
rely on the codegen or JVM backends.
@@ -0,0 +1,342 @@
+# coding=utf-8
+# Copyright 2015 Pants project contributors (see CONTRIBUTORS.md).

This comment has been minimized.

@jsirois

jsirois Nov 20, 2016

Member

I guess this was a move and so 2015 is OK.

@jsirois

jsirois Nov 20, 2016

Member

I guess this was a move and so 2015 is OK.

This comment has been minimized.

@benjyw

benjyw Nov 20, 2016

Contributor

Yeah, nothing in that file changed. AFAIK the goal of the copyright year is to establish prior authorship, so you want the earliest year than can reasonably be reasonable...

@benjyw

benjyw Nov 20, 2016

Contributor

Yeah, nothing in that file changed. AFAIK the goal of the copyright year is to establish prior authorship, so you want the earliest year than can reasonably be reasonable...

@benjyw benjyw merged commit e966210 into pantsbuild:master Nov 20, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:simple_codegen_task branch Nov 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment