Fixup OSX bintray prep. #4086

Merged
merged 1 commit into from Nov 21, 2016

Conversation

Projects
None yet
4 participants
@jsirois
Member

jsirois commented Nov 20, 2016

Previously CACHE_TARGET_DIR was being sourced from bootstrap.sh as a
readonly variable and an attempt to re-define it locally was failing
leading to an incorrect value.

Fixup OSX bintray prep.
Previously CACHE_TARGET_DIR was being sourced from bootstrap.sh as
a readonly variable and an attempt to re-define it locally was failing
leading to an incorrect value.
@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Nov 20, 2016

Member

Closes #4085

Member

jsirois commented Nov 20, 2016

Closes #4085

@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Nov 20, 2016

Member

NB: This will not be exercised until it lands on master, at which point we should have OSX binaries published for https://bintray.com/pantsbuild/bin/native-engine/538c578313e7557de31b62f90f193d5430334de7#files/build-support/bin/native-engine/linux

Member

jsirois commented Nov 20, 2016

NB: This will not be exercised until it lands on master, at which point we should have OSX binaries published for https://bintray.com/pantsbuild/bin/native-engine/538c578313e7557de31b62f90f193d5430334de7#files/build-support/bin/native-engine/linux

@mateor

mateor approved these changes Nov 21, 2016

@mateor mateor merged commit 8d4eace into pantsbuild:master Nov 21, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois removed the reviewable label Nov 21, 2016

@jsirois jsirois deleted the jsirois:jsirois/issues/4085 branch Nov 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment