New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a test bug that was exposed by me upgrading to Mac OS Sierra. #4087

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
4 participants
@benjyw
Contributor

benjyw commented Nov 20, 2016

Problem

After a recent OS X upgrade test_resolve_multiplatform_requirements failed because
the current platform became macosx-10.11-x86_64, for which cffi has no separate
wheel (yet?) Instead, that requirement is satisfied via compatibility with macosx-10.10-x86_64.

Solution

Don't check for the current platform, just the ones we hard-coded (but we still
resolve for the current platform so we can run the code on it).

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Nov 20, 2016

Contributor

Note that commit msg is inaccurate: I wasn't upgrading to sierra, it was some other, minor release upgrade. Still not sure exactly why that would have exposed this problem, since I've been on 10.11 for a long time, and that shouldn't have changed.

Nonetheless, the problem is real, so...

Contributor

benjyw commented Nov 20, 2016

Note that commit msg is inaccurate: I wasn't upgrading to sierra, it was some other, minor release upgrade. Still not sure exactly why that would have exposed this problem, since I've been on 10.11 for a long time, and that shouldn't have changed.

Nonetheless, the problem is real, so...

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Nov 22, 2016

Contributor

Reassigning to kwlzn since jsirois is AFK for a few days, and I want to get this in before I leave on vacay tonight.

Contributor

benjyw commented Nov 22, 2016

Reassigning to kwlzn since jsirois is AFK for a few days, and I want to get this in before I leave on vacay tonight.

@stuhood stuhood added the reviewable label Nov 22, 2016

@stuhood

This comment has been minimized.

Show comment
Hide comment
@stuhood

stuhood Nov 22, 2016

Member

@benjyw : A reminder: please use the reviewable label.

Member

stuhood commented Nov 22, 2016

@benjyw : A reminder: please use the reviewable label.

@kwlzn

kwlzn approved these changes Nov 22, 2016

seems reasonable to me.

@benjyw benjyw merged commit fee4a63 into pantsbuild:master Nov 22, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:resolve_test_fix branch Nov 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment