New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover compile-zinc-name-hashing option to follow deprecation cycle #4091

Merged
merged 1 commit into from Nov 22, 2016

Conversation

Projects
None yet
4 participants
@peiyuwang
Contributor

peiyuwang commented Nov 22, 2016

Problem

https://rbcommons.com/s/twitter/r/4342 removed compile-zinc-name-hashing before marking it as deprecated first. It's not supported by zinc/zinc wrapper but still should follow the proper deprecation cycle

Solution

Add it back with a deprecation warning.

Result

--[no-]compile-zinc-name-hashing (default: False)
    Use zinc name hashing.
    DEPRECATED. will be removed in version: 1.4.0.
    Name hashing is required for operation in zinc 1.0.0-X: this option no longer has any effect.
@kwlzn

kwlzn approved these changes Nov 22, 2016

lgtm

@stuhood

Thanks!

@peiyuwang peiyuwang merged commit 441c30b into pantsbuild:master Nov 22, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mateor

Weird, can not hit Approve after it lands.
Anyway, I "Approve".

Thanks peiyu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment