Run the proto compiler in workunit. #4092

Merged
merged 3 commits into from Nov 28, 2016

Conversation

Projects
None yet
4 participants
@benjyw
Contributor

benjyw commented Nov 23, 2016

Makes it easier to see the full cmd line/stdout/stderr, to debug problems.

Run the proto compiler in workunit.
So it's easy to see its command line, stdout/err etc.

benjyw added some commits Nov 23, 2016

Don't modify the engine version.
Not sure what's going on there, but I certainly didn't intend
to modify this file.
+ stdout=workunit.output('stdout'),
+ stderr=workunit.output('stderr'))
+ if result != 0:
+ raise TaskError('{} ... exited non-zero ({})'.format(self.protobuf_binary, result))

This comment has been minimized.

@wisechengyi

wisechengyi Nov 24, 2016

Contributor

While you are at it, do you think it would be more user friendly to show the command as well? e.g. https://github.com/wisechengyi/pants/blob/1e45167fab9a30f32207d025d91d2a071c8981fe/src/python/pants/backend/graph_info/tasks/cloc.py#L71-L71?

@wisechengyi

wisechengyi Nov 24, 2016

Contributor

While you are at it, do you think it would be more user friendly to show the command as well? e.g. https://github.com/wisechengyi/pants/blob/1e45167fab9a30f32207d025d91d2a071c8981fe/src/python/pants/backend/graph_info/tasks/cloc.py#L71-L71?

@stuhood stuhood merged commit f3f6f01 into pantsbuild:master Nov 28, 2016

1 of 2 checks passed

coverage/coveralls Coverage pending from Coveralls.io
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:run_protoc_in_workunit branch Dec 5, 2016

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Dec 5, 2016

Contributor

@stuhood Thanks for merging this while I was AFK.

Contributor

benjyw commented Dec 5, 2016

@stuhood Thanks for merging this while I was AFK.

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Run the proto compiler in workunit. (#4092)
Makes it easier to see the full cmd line/stdout/stderr, to debug problems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment