Bump setuptools version. #4103

Merged
merged 6 commits into from Dec 1, 2016

Conversation

@kwlzn
Member

kwlzn commented Nov 29, 2016

Problem

Currently, the version of setuptools used by pants is quite old and does not support PEP440 local version identifiers. Local version identifiers are useful for appending additional local context onto the end of a requirement version. In the most immediate case, this will enable us and others to suffix pants' own dists with the precise sha they were built from (e.g. pantsbuild.pants.contrib.go-1.3.0dev2+<SHA>.tar.gz) in a PEP-440 compliant manner. This functionality is also generally useful for pants users who have to work with python dependencies and resolution.

Solution

Bump setuptools to 20.10.1, the earliest version in which local version identifiers were supported. Additionally, because of implicit version handling in the newer setuptools the pants version has been made explicitly its canonical version (note the added . between 1.3.0 and dev2):

>>> from packaging.version import Version
>>> Version('1.3.0dev2')
<Version('1.3.0.dev2')>

Result

Pants should now be able to resolve packages with local version identifiers.

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn Nov 30, 2016

Member

N.B. this is a continuation of an initial review that @baroquebobcat put out in https://rbcommons.com/s/twitter/r/4284/

Member

kwlzn commented Nov 30, 2016

N.B. this is a continuation of an initial review that @baroquebobcat put out in https://rbcommons.com/s/twitter/r/4284/

@kwlzn kwlzn added the python label Nov 30, 2016

@kwlzn

This comment has been minimized.

Show comment
Hide comment
@kwlzn

kwlzn Dec 1, 2016

Member

FYI: extended testing of this change in our monorepo revealed resolve breakage with 20.2.2, which went away after a version bump to 20.10.1.

Member

kwlzn commented Dec 1, 2016

FYI: extended testing of this change in our monorepo revealed resolve breakage with 20.2.2, which went away after a version bump to 20.10.1.

@stuhood

stuhood approved these changes Dec 1, 2016

@kwlzn kwlzn merged commit 5e538f3 into pantsbuild:master Dec 1, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Bump setuptools version. (#4103)
Problem

Currently, the version of setuptools used by pants is quite old and does not support PEP440 local version identifiers. Local version identifiers are useful for appending additional local context onto the end of a requirement version. In the most immediate case, this will enable us and others to suffix pants' own dists with the precise sha they were built from (e.g. pantsbuild.pants.contrib.go-1.3.0dev2+<SHA>.tar.gz) in a PEP-440 compliant manner. This functionality is also generally useful for pants users who have to work with python dependencies and resolution.

Solution

Bump setuptools to 20.10.1, the earliest version in which local version identifiers were supported. Additionally, because of implicit version handling in the newer setuptools the pants version has been made explicitly its canonical version (note the added . between 1.3.0 and dev2):

>>> from packaging.version import Version
>>> Version('1.3.0dev2')
<Version('1.3.0.dev2')>
Result

Pants should now be able to resolve packages with local version identifiers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment