Adding section to describe building multiplatform python binaries wit… #4119

Merged
merged 2 commits into from Dec 5, 2016

Conversation

Projects
None yet
4 participants
@fcondon
Contributor

fcondon commented Dec 5, 2016

Problem

I asked in the pantsbuild slack about patterns for making wheel files available at build time for multi-platform python binaries and chatted with folks about the best way to store and reference wheel files. There's not much official existing documentation about multi-platform python binaries.

Solution

I added a section to the "Python 3rdparty Pattern" page describing where I ended up, drawing in part from @ericzundel's stack overflow post on the topic (http://stackoverflow.com/questions/34979100/pants-includes-os-x-specific-python-wheels)

Result

This is purely a documentation change.

@fcondon

This comment has been minimized.

Show comment
Hide comment
@fcondon

fcondon Dec 5, 2016

Contributor

@stuhood @kwlzn this is the doc change for what we were chatting about in slack!

Contributor

fcondon commented Dec 5, 2016

@stuhood @kwlzn this is the doc change for what we were chatting about in slack!

@lahosken

This comment has been minimized.

Show comment
Hide comment
@lahosken

lahosken Dec 5, 2016

Member

Bonus points if you're inspired to add something to http://www.pantsbuild.org/setup_repo.html to the currently-tiny doc about python-repos

Member

lahosken commented Dec 5, 2016

Bonus points if you're inspired to add something to http://www.pantsbuild.org/setup_repo.html to the currently-tiny doc about python-repos

@kwlzn

kwlzn approved these changes Dec 5, 2016

lgtm! thanks for adding this.

+<a href="https://pip.pypa.io/en/stable/reference/pip_wheel/">wheel</a> files for each platform
+available at build time.
+
+You can store these files on the web formatted in a link detection-friendly format or locally in

This comment has been minimized.

@baroquebobcat

baroquebobcat Dec 5, 2016

Contributor

It feels like this paragraph needs a bit more intro. I think it would be helpful to introduce the idea of a repo before explaining the two kinds of repos.

@baroquebobcat

baroquebobcat Dec 5, 2016

Contributor

It feels like this paragraph needs a bit more intro. I think it would be helpful to introduce the idea of a repo before explaining the two kinds of repos.

@fcondon

This comment has been minimized.

Show comment
Hide comment
@fcondon

fcondon Dec 5, 2016

Contributor

Maybe better to keep all [python-repos] examples on the "Setting up Pants" page. Not exactly what you suggested, but does this feel clearer @baroquebobcat?

Contributor

fcondon commented Dec 5, 2016

Maybe better to keep all [python-repos] examples on the "Setting up Pants" page. Not exactly what you suggested, but does this feel clearer @baroquebobcat?

@baroquebobcat

This comment has been minimized.

Show comment
Hide comment
@baroquebobcat

baroquebobcat Dec 5, 2016

Contributor

Yes. Thanks!

Contributor

baroquebobcat commented Dec 5, 2016

Yes. Thanks!

@fcondon

This comment has been minimized.

Show comment
Hide comment
@fcondon

fcondon Dec 5, 2016

Contributor

I believe a committer needs to merge this but I'm all set with it! @baroquebobcat?

Contributor

fcondon commented Dec 5, 2016

I believe a committer needs to merge this but I'm all set with it! @baroquebobcat?

@baroquebobcat baroquebobcat merged commit 804c978 into pantsbuild:master Dec 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment