Plumb a configurable worker count to thrift linter. #4121

Merged
merged 1 commit into from Dec 5, 2016

Conversation

Projects
None yet
3 participants
@kwlzn
Member

kwlzn commented Dec 5, 2016

Problem

In environments such as CI where multiprocessing.cpu_count() can be higher than expected (on the order of 12-24+), the recent thrift linter parallelization can cause a run on heap space within the same nailgun process resulting in OOM errors.

Solution

Plumb an option to control this via pants.ini.

Result

Worker count is now configurable.

@stuhood

stuhood approved these changes Dec 5, 2016

Thanks!

@kwlzn kwlzn merged commit eae290f into pantsbuild:master Dec 5, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Plumb a configurable worker count to thrift linter. (#4121)
Problem

In environments such as CI where multiprocessing.cpu_count() can be higher than expected (on the order of 12-24+), the recent thrift linter parallelization can cause a run on heap space within the same nailgun process resulting in OOM errors.

Solution

Plumb an option to control this via pants.ini.

Result

Worker count is now configurable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment