Redirect bootstrapping calls in pants binary to stderr #4131

Merged
merged 1 commit into from Dec 8, 2016

Conversation

Projects
None yet
3 participants
@baroquebobcat
Contributor

baroquebobcat commented Dec 8, 2016

I'm testing my hypothesis that these are what cause the intermittent CI failures

Redirect bootstrapping calls in pants binary to stderr
I'm testing my hypothesis that these are what cause the intermittent CI failures
@stuhood

stuhood approved these changes Dec 8, 2016

@kwlzn

kwlzn approved these changes Dec 8, 2016

@baroquebobcat baroquebobcat merged commit 136eeb4 into pantsbuild:master Dec 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Redirect bootstrapping calls in pants binary to stderr (#4131)
### Problem
CI fails intermittently in the pre-commit checks while attempting to run `isort.sh`. My hypothesis is that it is because the bootstrap and activation parts of the pants script are echoing things to stdout. `isort.sh` runs `./pants changed` and tees the results into a file, assuming that only target specs will be added to the file. If bootstrap were to write to stdout, it would cause problems when the specs were passed to the fmt.isort call.

### Solution
This patch redirects the activation and bootstrap calls' stdout to stderr which ensures they will not interfere even if they have writes to stdout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment