Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactor the thrift codegen task. #4155
OK, this is ready to be reviewed now. @wisechengyi - can you check that the change to the export test is OK? I'm assuming that the plugin (and anything else that consumes the export) doesn't expect the literal name
Thanks Benjy! This looks like a very nice improvement... looking forward to removal of the thrift builder code.
Just a few issues.