New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zinc and default scala-platform in pants repo to 2.11 #4176

Merged
merged 8 commits into from Jan 11, 2017

Conversation

Projects
None yet
3 participants
@peiyuwang
Contributor

peiyuwang commented Jan 11, 2017

Problem

This is a minor version bump in order to pick up sbt/zinc#204

Since 1.0.0-X7, zinc stopped publishing 2.10 artifacts. What this means for pantsbuild/zinc is now it needs to switch to 2.11. Compiling 2.10 source will continue to work because of bridge.

Solution

Upgraded versions in various places.

Result

After this, will publish the new pantsbuild/zinc and consume from python.

@stuhood

Note that the default scala-platform is already 2.12, so you should fix the title: this only affects the scala version in use in the pantsbuild/pants repo.

@peiyuwang peiyuwang changed the title from Upgrade zinc and default scala-platform to 2.11 to Upgrade zinc and default scala-platform in pants repo to 2.11 Jan 11, 2017

@peiyuwang peiyuwang merged commit bae5cc8 into pantsbuild:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mateor

LGTM - but I don't have an approve button on this review? Perhaps some subtle UI change...

We have not consumed the 1.0.0 upgrade yet, though. I have it around 85% of the way there - I requires that I dig through the code base and refactor every codegen target that results in an empty Scala file.

There aren't very many and they are all legacy things that should be refactored - but I wanted to get the 1.2x upgrade landed first.

@mateor

This comment has been minimized.

Show comment
Hide comment
@mateor

mateor Jan 11, 2017

Member

Ah - maybe because it landed already. Welp.

Member

mateor commented Jan 11, 2017

Ah - maybe because it landed already. Welp.

@peiyuwang

This comment has been minimized.

Show comment
Hide comment
@peiyuwang

peiyuwang Jan 11, 2017

Contributor

@mateor sorry, should have waited longer, thought this is a small change, but didn't realize you haven't consumed the 1.0.0 upgrade yet.

This is a 3 step process, jvm, publish, then consume from python, I can hold the python change till you are ready?

refactor every codegen target that results in an empty Scala file.

ditto this, that's probably the main change in order to consume the 1.0.0 zinc.

Contributor

peiyuwang commented Jan 11, 2017

@mateor sorry, should have waited longer, thought this is a small change, but didn't realize you haven't consumed the 1.0.0 upgrade yet.

This is a 3 step process, jvm, publish, then consume from python, I can hold the python change till you are ready?

refactor every codegen target that results in an empty Scala file.

ditto this, that's probably the main change in order to consume the 1.0.0 zinc.

@peiyuwang peiyuwang deleted the peiyuwang:peiyu/zinc-1.0.0.X7 branch Jan 18, 2017

@peiyuwang peiyuwang referenced this pull request Mar 24, 2017

Closed

Release pantsbuild zinc #4380

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Upgrade zinc and default scala-platform in pants repo to 2.11 (#4176)
### Problem

This is a minor version bump in order to pick up sbt/zinc#204

Since `1.0.0-X7`, zinc stopped publishing `2.10` [artifacts](https://mvnrepository.com/artifact/org.scala-sbt/zinc_2.10). What this means for pantsbuild/zinc is now it needs to switch to `2.11`. Compiling `2.10` source will continue to work because of bridge.

### Solution

Upgraded versions in various places.

### Result

After this, will publish the new `pantsbuild/zinc` and consume from python.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment