Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Scrooge codegen improvements #4177
Scrooge codegen does not do fingerprinting for enough facets and is
Add support for include-path and default-java-namespace.
Fix the fingerprinting to include namespace_map, include_path and
Scrooge support is now good enough for to be used for development
reviewers: apologies in advance for my lack of python and pants knowledge.
also note that i tested my changes on a earlier commit and it looks like some of the codegen code got moved around since then. that means my confidence level is not super high given the levels of test coverage i experienced.
@kevinoliver : It should be relatively easy to add an integration test for this by cloning https://github.com/pantsbuild/pants/blob/master/contrib/scrooge/tests/python/pants_test/contrib/scrooge/tasks/test_thrift_linter_integration.py into a new file
There is also an