Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Removes the slf4j implementation from the classpath when running Cobertura #4198
The Cobertura plugin adds SLF4J to the classpath when generating code coverage; as a result it's not possible to run tests that depend on using their own slf4j implementation.
Removed slf4j-simple from the Cobertura runtime classpath.
There is no slf4j implementation on the classpath when coverage is generate unless an implementation is added by the user.
If Cobertura fails then it's logging output will be directed to the SLF4J NOOP logging implementation (so it will fail silently).
referenced this pull request
Jan 24, 2017
LGTM. The CI failure is not your problem, but it blocks merging. Its also affecting a PR of mine (#4201). The issue is tracked by #4204 which #4201 may provide a short-term fix for. As soon as that fix is in master, a rebase here will be needed to pick the fix up and hopefully get this branch green under travis.