A task to generate Python code from ANTLR3 grammars. #4206

Merged
merged 1 commit into from Jan 28, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Jan 25, 2017

This is intended to supersede the existing AntlrBuilder
from the old Python pipeline. It does not add new features
and does not share any code with the Java ANTLR task.
That is left as future work.

Also rearranges the old ANTLR testprojects, removes cruft
and adds various tweaks and TODOs to the Java ANTLR task.

The change isn't as big as it looks - most of it is moving and
deleting files.

A task to generate Python code from ANTLR3 grammars.
This is intended to supercede the existing AntlrBuilder
in the old Python pipeline. It does not add new features
and does not share any code with the Java ANTLR task.
That is left as future work.

Also rearranges the old ANTLR testprojects, removes cruft
and adds various tweaks and TODOs to the Java ANTLR task.

@benjyw benjyw requested review from stuhood and kwlzn Jan 26, 2017

@kwlzn

kwlzn approved these changes Jan 27, 2017

lgtm

+logger = logging.getLogger(__name__)
+
+
+_ANTLR3_REV = '3.1.3'

This comment has been minimized.

@kwlzn

kwlzn Jan 27, 2017

Member

is there no way to make this configurable?

@kwlzn

kwlzn Jan 27, 2017

Member

is there no way to make this configurable?

This comment has been minimized.

@benjyw

benjyw Jan 28, 2017

Contributor

There surely is, but the goal here was just parity with the old Python ANTLR builder, so we can kill it. Having this be configurable would be best done as part of merging the implementations of this and the Java ANTLR gen task, thus supporting ANTLR4, multiple versions, etc etc.

@benjyw

benjyw Jan 28, 2017

Contributor

There surely is, but the goal here was just parity with the old Python ANTLR builder, so we can kill it. Having this be configurable would be best done as part of merging the implementations of this and the Java ANTLR gen task, thus supporting ANTLR4, multiple versions, etc etc.

@benjyw benjyw merged commit b2c1331 into pantsbuild:master Jan 28, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:py_antlr branch Jan 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment