Deprecate use of resources= in JVM targets. #4248

Merged
merged 2 commits into from Feb 11, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Feb 11, 2017

No description provided.

@benjyw benjyw requested a review from stuhood Feb 11, 2017

@stuhood

Thanks!

@@ -74,6 +75,9 @@ def __init__(self,
rollbacks, but in certain cases may conflict with user libraries.
:type zinc_file_manager: bool
"""
+ deprecated_conditional(lambda: resources is not None, '1.5.0dev0',
+ 'The `resources=` JVM target argument', 'Use `dependences=` instead.')

This comment has been minimized.

@stuhood

stuhood Feb 11, 2017

Member

s/dependences/dependencies/

@stuhood

stuhood Feb 11, 2017

Member

s/dependences/dependencies/

@benjyw benjyw merged commit d32b23a into pantsbuild:master Feb 11, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@benjyw benjyw deleted the benjyw:deprecate_resources branch Feb 11, 2017

@@ -74,6 +75,9 @@ def __init__(self,
rollbacks, but in certain cases may conflict with user libraries.
:type zinc_file_manager: bool
"""
+ deprecated_conditional(lambda: resources is not None, '1.5.0dev0',

This comment has been minimized.

@wisechengyi

wisechengyi Feb 11, 2017

Contributor

sorry a bit late. 1.5.0dev0 -> 1.5.0.dev0

@wisechengyi

wisechengyi Feb 11, 2017

Contributor

sorry a bit late. 1.5.0dev0 -> 1.5.0.dev0

This comment has been minimized.

@benjyw

benjyw Feb 11, 2017

Contributor

Are you sure? That's not the form mentioned in the release docs (mostly).

I see both forms in the code.

@benjyw

benjyw Feb 11, 2017

Contributor

Are you sure? That's not the form mentioned in the release docs (mostly).

I see both forms in the code.

This comment has been minimized.

@wisechengyi

wisechengyi Feb 11, 2017

Contributor

i think so, also 4289340 just went in.

@wisechengyi

wisechengyi Feb 11, 2017

Contributor

i think so, also 4289340 just went in.

This comment has been minimized.

@benjyw

benjyw Feb 11, 2017

Contributor

Either way, we should clean this up uniformly in a separate change (I had already pushed this one).

@benjyw

benjyw Feb 11, 2017

Contributor

Either way, we should clean this up uniformly in a separate change (I had already pushed this one).

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment