Treat PythonTarget dependencies on Resources targets appropriately. #4249

Merged
merged 1 commit into from Feb 11, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Feb 11, 2017

target.resources will now iterate over those, as well as the other
two ways of specifying resources.

Also simplifies that iteration: all ways of specifying python target
resources end up in the traversable_dependency_specs, so there's
no need for target.resources to laboriously handle each way separately,
as it did before.

Treat PythonTarget dependencies on Resources targets appropriately.
target.resources will now iterate over those, as well as the other
two ways of specifying resources.

Also simplifies that iteration: all ways of specifying python target
resources end up in the traversable_dependency_specs, so there's
no need for target.resources() to laboriously handle each way separately,
as it did before.

@benjyw benjyw requested a review from stuhood Feb 11, 2017

@stuhood

Well... that was unexpected!

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Feb 11, 2017

Contributor

I know, right? So close...

Contributor

benjyw commented Feb 11, 2017

I know, right? So close...

@benjyw benjyw merged commit 78ad33e into pantsbuild:master Feb 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:python_resource_deps branch Feb 11, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Treat PythonTarget dependencies on Resources targets appropriately. (#…
…4249)

target.resources will now iterate over those, as well as the other
two ways of specifying resources.

Also simplifies that iteration: all ways of specifying python target
resources end up in the traversable_dependency_specs, so there's
no need for target.resources() to laboriously handle each way separately,
as it did before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment