Small tweak to the Dockerfile. #4263

Merged
merged 1 commit into from Feb 23, 2017

Conversation

Projects
None yet
3 participants
@benjyw
Contributor

benjyw commented Feb 15, 2017

No description provided.

@benjyw benjyw requested a review from mateor Feb 15, 2017

-RUN git clone https://github.com/pantsbuild/pants.git && cd /pants && ./pants
+# The bootstrapping run of ./pants may not return exit code 0 due to unimportant warnings,
+# so we force the exit code to 0, allowing docker build to complete.
+RUN git clone https://github.com/pantsbuild/pants.git && cd /pants && (./pants || :)

This comment has been minimized.

@wisechengyi

wisechengyi Feb 15, 2017

Contributor

how about ./pants goals so no need to force exit 0?

@wisechengyi

wisechengyi Feb 15, 2017

Contributor

how about ./pants goals so no need to force exit 0?

This comment has been minimized.

@benjyw

benjyw Feb 16, 2017

Contributor

I don't thin that will solve the problem. Why should ./pants goals return 0 when ./pants does not?

@benjyw

benjyw Feb 16, 2017

Contributor

I don't thin that will solve the problem. Why should ./pants goals return 0 when ./pants does not?

This comment has been minimized.

@wisechengyi

wisechengyi Feb 16, 2017

Contributor

because

$ ./pants
No goals specified.
Use `pants goals` to list goals.
Use `pants help` to get help.
[tw-mbp-yic source (master)]$ echo $?
1
@wisechengyi

wisechengyi Feb 16, 2017

Contributor

because

$ ./pants
No goals specified.
Use `pants goals` to list goals.
Use `pants help` to get help.
[tw-mbp-yic source (master)]$ echo $?
1

This comment has been minimized.

@benjyw

benjyw Feb 16, 2017

Contributor

Oh hmm, that's unintuitive. But that may indeed have been the only problem, not the bootstrapping issues. Will change and see.

@benjyw

benjyw Feb 16, 2017

Contributor

Oh hmm, that's unintuitive. But that may indeed have been the only problem, not the bootstrapping issues. Will change and see.

@mateor

mateor approved these changes Feb 16, 2017

I am okay with forcing zero here since it is just for pants-dev use, but printing out the goals isn't the worst thing in the world.

@benjyw benjyw merged commit b0b1ada into pantsbuild:master Feb 23, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@benjyw benjyw deleted the benjyw:dockerfile_tweak branch Feb 23, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment