Upgrade default go to 1.8. #4272

Merged
merged 2 commits into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@jsirois
Member

jsirois commented Feb 19, 2017

Release notes are here: https://golang.org/doc/go1.8

@jsirois jsirois requested a review from benjyw Feb 19, 2017

@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Feb 19, 2017

Member

Aha - go 1.8 change to GOPATH behavior: https://golang.org/doc/go1.8#gopath
Contemplating correct response...

Member

jsirois commented Feb 19, 2017

Aha - go 1.8 change to GOPATH behavior: https://golang.org/doc/go1.8#gopath
Contemplating correct response...

@jsirois

This comment has been minimized.

Show comment
Hide comment
@jsirois

jsirois Feb 20, 2017

Member

Relevant issue fixed that leads to this failure under 1.8: #2321

Member

jsirois commented Feb 20, 2017

Relevant issue fixed that leads to this failure under 1.8: #2321

@mateor

mateor approved these changes Feb 21, 2017

lgtm

@jsirois jsirois merged commit 4b05fde into pantsbuild:master Feb 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jsirois jsirois deleted the jsirois:jsirois/go/upgrade branch Feb 21, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment