[New Python Pipeline] Add resources to PEXes correctly. #4275

Merged
merged 1 commit into from Feb 21, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Feb 21, 2017

Previously the builder would add __init__.py files to resource dirs,
which is not what we want.

Also fixes the engine tests, that were relying on being run out of
the source tree, and so weren't correctly depending on the resources
they use.

[New Python Pipeline] Add resources to PEXes correctly.
Previously the builder would add __init__.py files to resource dirs,
which is not what we want.

Also fixes the engine tests, that were relying on being run out of
the source tree, and so weren't correctly depending on the resources
they use.

@benjyw benjyw requested review from kwlzn and stuhood Feb 21, 2017

@kwlzn

kwlzn approved these changes Feb 21, 2017

lgtm. thanks!

@benjyw benjyw merged commit cafe833 into pantsbuild:master Feb 21, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_engine_tests branch Feb 21, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

[New Python Pipeline] Add resources to PEXes correctly. (#4275)
Previously the builder would add __init__.py files to resource dirs,
which is not what we want.

Also fixes the engine tests, that were relying on being run out of
the source tree, and so weren't correctly depending on the resources
they use.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment