Strip the root-level __init__.py that apache thrift generates. #4281

Merged
merged 2 commits into from Feb 23, 2017

Conversation

Projects
None yet
2 participants
@benjyw
Contributor

benjyw commented Feb 22, 2017

It's superfluous, and actually causes problems in pex chroots.

Strip the root-level __init__.py that apache thrift generates.
It's superfluous, and actually causes problems in pex chroots.

@benjyw benjyw requested review from kwlzn and mateor Feb 22, 2017

@kwlzn

kwlzn approved these changes Feb 22, 2017

lgtm - assuming the __init__.py in question here is guaranteed to always be empty.

@benjyw

This comment has been minimized.

Show comment
Hide comment
@benjyw

benjyw Feb 22, 2017

Contributor

Yep, it's empty. And since pytest uses the presence or absence of __init__.py to infer source roots, its presence is actually problematic in the new python pipeline.

Contributor

benjyw commented Feb 22, 2017

Yep, it's empty. And since pytest uses the presence or absence of __init__.py to infer source roots, its presence is actually problematic in the new python pipeline.

@benjyw benjyw merged commit e62047d into pantsbuild:master Feb 23, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@benjyw benjyw deleted the benjyw:fix_python_thrift_init branch Feb 23, 2017

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

Strip the root-level __init__.py that apache thrift generates. (#4281)
It's superfluous, and actually causes problems in pex chroots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment