[engine] minor clean up `engine.close` usage in `visualizer` #4284

Merged
merged 1 commit into from Feb 24, 2017

Conversation

Projects
None yet
3 participants
@peiyuwang
Contributor

peiyuwang commented Feb 24, 2017

Problem

daf5dc4 removed engine.close as part of the storage clean up but there is still one usage by visualizer.

Solution

Remove the dead engine.close in visualizer

Result

Before

  File "/Users/peiyu/github/pants/.pants.d/python-setup/chroots/214a9a01b046594b9d6402b68728f0578dae2861/pants_test/engine/examples/visualizer.py", line 80, in main_addresses
    visualize_build_request(build_root, goals, spec_roots)
  File "/Users/peiyu/github/pants/.pants.d/python-setup/chroots/214a9a01b046594b9d6402b68728f0578dae2861/pants_test/engine/examples/visualizer.py", line 46, in visualize_build_request
    engine.close()
AttributeError: 'LocalSerialEngine' object has no attribute 'close'

After

dot file saved to: /var/folders/z8/hfw3c_sj25b2t3wmnlfq3kjm0000gn/T/tmp0xb6at.dot
svg file saved to: /var/folders/z8/hfw3c_sj25b2t3wmnlfq3kjm0000gn/T/tmpke3EvL.svg

10:30:40 00:12     [jvm]
10:30:40 00:12     [cpp]
10:30:40 00:12     [go]
10:30:40 00:12     [node]
10:30:40 00:12   [complete]
               SUCCESS

@peiyuwang peiyuwang requested review from baroquebobcat, stuhood and kwlzn Feb 24, 2017

@kwlzn

kwlzn approved these changes Feb 24, 2017

lgtm

@peiyuwang peiyuwang merged commit 42f959b into pantsbuild:master Feb 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

lenucksi added a commit to lenucksi/pants that referenced this pull request Apr 25, 2017

[engine] minor clean up `engine.close` usage in `visualizer` (#4284)
### Problem

daf5dc4 removed `engine.close` as part of the storage clean up but there is still one usage by `visualizer`.

### Solution

Remove the dead `engine.close` in `visualizer`

### Result

Before
```
  File "/Users/peiyu/github/pants/.pants.d/python-setup/chroots/214a9a01b046594b9d6402b68728f0578dae2861/pants_test/engine/examples/visualizer.py", line 80, in main_addresses
    visualize_build_request(build_root, goals, spec_roots)
  File "/Users/peiyu/github/pants/.pants.d/python-setup/chroots/214a9a01b046594b9d6402b68728f0578dae2861/pants_test/engine/examples/visualizer.py", line 46, in visualize_build_request
    engine.close()
AttributeError: 'LocalSerialEngine' object has no attribute 'close'
```

After
```
dot file saved to: /var/folders/z8/hfw3c_sj25b2t3wmnlfq3kjm0000gn/T/tmp0xb6at.dot
svg file saved to: /var/folders/z8/hfw3c_sj25b2t3wmnlfq3kjm0000gn/T/tmpke3EvL.svg

10:30:40 00:12     [jvm]
10:30:40 00:12     [cpp]
10:30:40 00:12     [go]
10:30:40 00:12     [node]
10:30:40 00:12   [complete]
               SUCCESS
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment